Add option to write log files to output directory - #180
Open
dpsarmie wants to merge 4 commits into
Open
Conversation
jiandewang
self-requested a review
July 16, 2026 14:54
Collaborator
|
@dpsarmie we will use squash merge as it has 4 mini commits which won't be accepted by MOM6 main repo. |
26 tasks
Author
Ok, I or the EPIC CMs will tag you once this PR and the UFS WM PR are picked up and tested. |
| character(len=16) :: timestr | ||
| character(len=256) :: fname | ||
| character(len=256) :: subname='MOM_cap:(outputlog_run)' | ||
| character(len=256), allocatable :: logdir |
Collaborator
There was a problem hiding this comment.
why is logdir allocatable?
Also, instead of having a check for if you want it going someplace else, why not have a config variable which would provide the location; if none were provided it would default to the cwd?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a feature request made by NCO for GFSv17 production to have the logs moved to the output folder for each component. This change was made for production (18ffcb1), however the production changes had no way to allow the user to turn the feature on or off. This PR will add a new option to ufs.configure that will allow the user to specify whether or not they want the logs to be written to the MOM6 output directory or the run directory. The default (if the option is not declared) will be to have the logs in the run directory.